Commit graph

74 commits

Author SHA1 Message Date
Dumitru Deveatii b5299f8ec3 sync changes from clean-code-javascript 2022-04-26 09:58:56 +03:00
Luís Guilherme Ferreira 66a0d8cd0b
Updated README.md to improve readability (#53)
At Functions should do one thing, the function emailClients is only emailing activeClients, thus the suggestion to make its name explicit for reliability purposes.
2022-04-17 18:02:19 +03:00
Bow Archer 14e3a9d711
Change implied variable name for consistency (#50) 2021-11-13 00:41:22 +02:00
Balázs Péczeli 2d09badb68
Fix typo (#49) 2021-11-13 00:36:58 +02:00
Alexander Böhm 2172a87caf
Switch formatting from TSLint to ESLint (#44) 2021-05-24 16:48:15 +03:00
Alexander Böhm 5abc856c30
Add german translation repo link (#42)
docs: add german translation
2021-03-12 18:30:35 +02:00
ParthoKR 4bc1eb503b
Enhanced readme, fixed some grammar (#40) 2021-01-26 14:13:15 +02:00
Dumitru b4d50cd711
docs: added Vietnamese translation 2020-07-14 15:35:32 +03:00
Dumitru 1c30f54c8d
added French translation reference 2020-06-20 10:49:47 +03:00
Dumitru c174a087f7
Add reference to Spanish translation 2020-06-16 08:43:49 +03:00
Jacob Galam c70fb6fd8a
Add type to isEmailUsed in Avoid negative conditionals (#36)
add string type to email argument in `isEmailUsed`
2020-05-25 09:47:24 +03:00
Junwoo Ji 8f52daaea4
fix: typo conscise -> concise (#34) 2020-04-21 15:46:02 +03:00
Junwoo Ji 1d2e3c2b2a
i18n: add korean translation repo link (#35) 2020-04-21 15:45:12 +03:00
Junwoo Ji 51bbb347ec
fix typo delactation -> declaration (#33)
* fix: added a missing semicolon

* fix: typo delactation -> declaration
2020-04-12 12:28:19 +03:00
Junwoo Ji 378805c358
fix: added a missing semicolon (#32) 2020-04-09 09:56:59 +03:00
Userbit 0658746e22
Fix links to basarat.gitbook.io (#30) 2020-02-05 13:55:10 +02:00
Dumitru cf79eeec72
sync improvements from clean-code-javascript repo (#29) 2020-01-31 19:01:53 +02:00
Dumitru d2c0c5f4d2
docs: linked Russian translation 2020-01-06 10:28:49 +02:00
Dumitru 4e8d2e9085
docs: reference Turkish translation #27 2019-12-02 12:12:06 +02:00
Victor Luca a00de960c5 Added enum example in variables section. (#25)
* Added enum example in variables section.

* Rethought the enum motivation and example.

* Fixed typo.
2019-05-30 15:02:11 +03:00
M.Sakamaki cff7d02f87 add const assertions in typescript 3.4 (#26)
* syntax error of type alias

* add const assertions

* have done fixed

* fix small reviews
2019-05-30 14:26:06 +03:00
kajetansw 4592b199e6 fixed usage of array type (#24) 2019-03-02 18:57:05 +02:00
Kiffie Liversage 15b1b550a4 Fix typo - "that" to "than" (#23) 2019-03-02 12:03:32 +02:00
Gagan Rai bc404ec6f8 Fixes (#22)
* Fixed usage of for-in loop in iterator example.

* Fixed typos.
2019-02-27 16:01:04 +02:00
Dumitru 563f4f6831
Added ref to Japanese translation 2019-02-19 09:42:13 +02:00
Dumitru f40dac21da
Added Chinese translation ref from @pipiliang 2019-02-18 10:16:55 +02:00
Dumitru d15055afc0
Added Chinese translation reference 2019-02-18 09:29:41 +02:00
Nicolas Dermine ddadce217e fix typo (#20) 2019-02-18 08:35:32 +02:00
Dumitru d66665d545
Added link to Brazilian Portuguese translation 2019-02-14 08:18:15 +02:00
M.Sakamaki 5c577fb5cc syntax error of type alias (#18) 2019-02-13 12:15:40 +02:00
Dumitru Deveatii 008e81797a Added translations section. 2019-02-12 08:55:19 +02:00
Dumitru Deveatii b0d7be06b7 Fix markdownlint formatting issues.
Added few missing references.
2019-02-12 08:40:50 +02:00
Dumitru b8a75392f4
Move type vs interface
From `Formatting` to `Objects and Data Structures` section.
2019-02-11 13:39:31 +02:00
Russu Vadim c46f8d7599 Grouping imports and typescript aliases (#16)
* Grouping imports and typescript aliases

* fix PR comments (rename section + tsconfig example)

* shorter import (Use typescript aliases Example)

* Adjust `Organize imports` description
2019-02-11 10:47:27 +02:00
dumitru.deveatii 2e1325b54e Use iterators and generators - fixed type 2019-02-09 23:30:35 +02:00
dumitru.deveatii 270e25a034 Use iterators and generators 2019-02-09 23:28:17 +02:00
dumitru.deveatii f0ba673e71 TODO comments. 2019-02-09 22:31:00 +02:00
Dumitru 07c68cbe9f
Fixed code duplication in flags sample 2019-02-07 23:42:21 +02:00
dumitru.deveatii b217d318c7 Fix samples / typos 2019-02-07 21:53:16 +02:00
IBlackI e5a292528f Fixed "good" example calling undefined variable.
> ###Remove duplicate code###
-> **Good:**
--> `developer` was called but never declared, should have been `employee`
2019-02-06 13:29:50 +02:00
Vadim Russu b0771b8e8c add missing semicolon 2019-02-06 10:51:46 +02:00
Vadim Russu 915c881855 more consistent formatting 2019-02-06 10:51:46 +02:00
Dumitru Deveatii a3564af820 ISP sample: review formatting 2019-02-06 10:40:08 +02:00
Dumitru Deveatii 58606c8fce added gitattributes 2019-02-06 10:09:32 +02:00
Dumitru Deveatii 5bffa13b56 Improve formatting and samples 2019-02-06 10:01:19 +02:00
MSakamaki 6c84c7a72b [Do not add unneeded context ] to gets an error correction 2019-02-06 07:47:26 +02:00
Dumitru Deveatii a06fa32967 suggestions from r/@AngularBeginner 2019-02-05 17:21:31 +02:00
Nik Mouzourides 9ae5fc71fd Load image over https to fix mixed content warning on https://labs42io.github.io/clean-code-typescript/ 2019-02-05 15:21:36 +02:00
Nik Mouzourides f5d8cb566a Fix addItemToCart example to return CartItem array instead of object 2019-02-05 15:08:58 +02:00
Dumitru Deveatii 4c6d10ce64 suggestions from r/@AngularBeginner 2019-02-05 14:22:16 +02:00