x/clean-code-typescript
1
0
Fork 0
mirror of https://github.com/labs42io/clean-code-typescript.git synced 2024-09-19 22:34:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Updated README.md to improve readability (#53)

Browse source 
At Functions should do one thing, the function emailClients is only emailing activeClients, thus the suggestion to make its name explicit for reliability purposes.
This commit is contained in:
Luís Guilherme Ferreira 2022-04-17 16:02:19 +01:00 committed by GitHub
parent 14e3a9d711
commit 66a0d8cd0b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -372,7 +372,7 @@ This is by far the most important rule in software engineering. When functions d
**Bad:**
```ts
function emailClients(clients: Client[]) {
function emailActiveClients(clients: Client[]) {
clients.forEach((client) => {
const clientRecord = database.lookup(client);
if (clientRecord.isActive()) {
@ -385,7 +385,7 @@ function emailClients(clients: Client[]) {
**Good:**
```ts
function emailClients(clients: Client[]) {
function emailActiveClients(clients: Client[]) {
clients.filter(isActiveClient).forEach(email);
}