x/clean-go-article
1
0
Fork 0
mirror of https://github.com/Pungyeon/clean-go-article.git synced 2024-11-23 14:14:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
120 commits 3 branches 0 tags 330 KiB
Commit graph

120 commits

This branch
This branch
All branches
Author SHA1 Message Date
Lasse Martin Jakobsen 50b1d72abf
Merge pull request #34 from jeffwalsh/key_id_typo 
Typo: 'id' should be 'key' in hashmap example
 2019-12-06 19:48:21 +01:00
Jeff Walsh 9256c081aa key typo in hashmap example 2019-12-03 16:17:39 -08:00
Lasse Martin Jakobsen 061ee338a3
Merge pull request #31 from Pungyeon/inverted_bool_checks 
changed bool checks to make sense
 2019-08-05 18:33:28 +02:00
Lasse Martin Jakobsen 708a68628a
Merge pull request #32 from Pungyeon/minor_cleanup 
changed made based on issue 28
 2019-08-05 10:44:41 +02:00
Lasse Martin Jakobsen a8493ef2e8 changed made based on issue 28 2019-08-05 10:41:05 +02:00
Lasse Martin Jakobsen 5272e93547 changed bool checks to make sense 2019-08-05 10:36:56 +02:00
Lasse Martin Jakobsen 1aead7e4d1
Merge pull request #29 from Pungyeon/embedded_interfaces_less_harsh 
Embedded Interfaces
 2019-07-29 10:34:27 +02:00
Lasse Martin Jakobsen d2307c8f36
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:52 +02:00
Lasse Martin Jakobsen 3605215928
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:42 +02:00
Lasse Martin Jakobsen 0f5b9126e8
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:32 +02:00
Lasse Martin Jakobsen 6920b78bc0
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:24 +02:00
Lasse Martin Jakobsen 384eaa6f30
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:11 +02:00
Lasse Martin Jakobsen eab8c21f28
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:15:58 +02:00
Lasse Martin Jakobsen 6bcff141fd
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:15:41 +02:00
Lasse Martin Jakobsen 2acf6d8020
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:15:22 +02:00
Lasse Martin Jakobsen 052a6003ea oopsie 2019-07-23 17:09:08 +02:00
Lasse Martin Jakobsen 306e2d7118 less aggressive language and more descriptive expalanation of the downsides of using embedded interfaces 2019-07-23 17:05:50 +02:00
Aleksandr Hovhannisyan 3860f0cf5c
Reword misleading sentence under Function Length 2019-07-12 18:51:10 -04:00
Lasse Martin Jakobsen 27f52da671
Merge pull request #27 from AleksandrHovhannisyan/soften_writing 
Soften tone of writing
 2019-07-11 16:51:43 +02:00
Lasse Martin Jakobsen f9cbc4f02b
Merge pull request #26 from Pungyeon/check_interface_contracts 
added suggestions from issue #1
 2019-07-11 16:48:45 +02:00
Aleksandr Hovhannisyan 60d84410e9 Soften tone of writing in accordance with issue #25 2019-07-11 07:51:41 -04:00
Lasse Martin Jakobsen 8530359ce4
Update README.md 
Co-Authored-By: Aleksandr H <aleksandrhovhannisyan@gmail.com>
 2019-07-11 13:20:14 +02:00
Lasse Martin Jakobsen cf168cce6e
Update README.md 
Co-Authored-By: Aleksandr H <aleksandrhovhannisyan@gmail.com>
 2019-07-11 13:20:04 +02:00
Lasse Martin Jakobsen 828fd65cfa added suggestions from issue #1 2019-07-11 10:16:50 +02:00
Lasse Martin Jakobsen 10f2accf24 added suggestions from issue #1 2019-07-11 10:15:10 +02:00
Aleksandr H 4fb8a38c95
Fix typo: each others' should be each other's 2019-07-02 21:35:05 -04:00
Aleksandr H 125fc47b3b
Fix typo and clean up wording under Variable Scope 2019-07-02 21:28:30 -04:00
Lasse Martin Jakobsen efe7d709b3
Typo fix 2019-07-02 16:14:41 +02:00
Lasse Martin Jakobsen 1f5e6b3f04
Merge pull request #24 from jdugarte/patch-2 
Update README.md
 2019-07-02 16:11:29 +02:00
Jesus Dugarte b1abbd0cdf
Update README.md 2019-07-01 13:01:33 -04:00
Lasse Martin Jakobsen 0b0471eb57
Merge pull request #20 from AleksandrHovhannisyan/final-edits 
Edit rest of document (The empty interface and Summary)
 2019-07-01 15:17:45 +02:00
Aleksandr H f7bc37da6d
Accept suggestion: Clarify writing on generics and interface{} 
Co-Authored-By: Lasse Martin Jakobsen <lmj@corti.ai>
 2019-07-01 09:15:37 -04:00
Aleksandr H e9066232cd
Replace "hidden" with "contained" 
Per Pungyeon's suggestion
 2019-07-01 09:03:37 -04:00
Aleksandr H a24cd89e5c
Merge branch 'master' into final-edits 2019-07-01 09:00:20 -04:00
Lasse Martin Jakobsen de77dfcdcb
Merge pull request #12 from AleksandrHovhannisyan/master 
Edit writing up until "The empty interface{}"
 2019-07-01 14:58:54 +02:00
Aleksandr H 0d8bea3073
Accept suggestion: replace "&mdash;ones" with " that" 
Co-Authored-By: Lasse Martin Jakobsen <lmj@corti.ai>
 2019-07-01 08:57:49 -04:00
Aleksandr H a736c49af1
Merge branch 'master' into master 2019-07-01 08:56:12 -04:00
Aleksandr H 5ecca2ca95
Accept suggestion: replace "that point" with "pointing" 
Co-Authored-By: Lasse Martin Jakobsen <lmj@corti.ai>
 2019-07-01 08:52:18 -04:00
Lasse Martin Jakobsen ed66405676
Merge pull request #14 from seaskyways/patch-1 
Update README.md
 2019-07-01 07:17:30 +02:00
Lasse Martin Jakobsen 6687e3141c
Merge pull request #16 from hartzell/patch-1 
Typo: missing ';' ruins emdash
 2019-07-01 07:16:29 +02:00
Lasse Martin Jakobsen 038dd4c940
Merge branch 'master' into patch-1 2019-07-01 07:15:51 +02:00
Lasse Martin Jakobsen 9093cf6492
Merge pull request #19 from jdugarte/patch-1 
Update README.md
 2019-07-01 07:14:29 +02:00
Lasse Martin Jakobsen aef58c4d06
Merge pull request #17 from hartzell/patch-2 
Typo: ErrInsufficientPrivliges -> ErrInsufficientPrivileges
 2019-07-01 07:10:13 +02:00
Lasse Martin Jakobsen df41cac4a1
Merge pull request #18 from hartzell/typos 
Typos and formatting fixes:
 2019-07-01 07:09:08 +02:00
Lasse Martin Jakobsen b0b869f519
Merge pull request #13 from chuhlomin/patch-1 
Fixed #Naming-Conventions anchor link
 2019-07-01 07:07:23 +02:00
Aleksandr Hovhannisyan f159685f10 Edit rest of document 2019-06-30 09:08:33 -04:00
Jesus Dugarte b9509f6a94
Update README.md 2019-06-29 23:31:17 -04:00
hartzell ce330d2cbb Typos and formatting fixes: 
- not -> note
- an -> and
- fixed indentation in code example by running it through `gofmt`
 2019-06-29 09:26:46 -07:00
George Hartzell 759fbbae0f
Typo: ErrInsufficientPrivliges -> ErrInsufficientPrivileges 
The compiler would have caught this....
 2019-06-29 09:08:38 -07:00
George Hartzell e23a62d567
Typo: missing ';' ruins emdash 
There's an `&mdash` that needs to be an `&emdash;`.
 2019-06-29 09:03:22 -07:00