x/clean-go-article
1
0
Fork 0
mirror of https://github.com/Pungyeon/clean-go-article.git synced 2024-09-19 22:34:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
135 commits 3 branches 0 tags 330 KiB
Commit graph

135 commits

This branch
This branch
All branches
Author SHA1 Message Date
Lasse Martin Jakobsen f18fd5f884
Merge pull request #46 from saireddyavs/master 
Update README.md
 2023-01-31 16:24:34 +01:00
Avuluri Venkata Sai Reddy 7e2ba16f20
update readme, fix formatting 2023-01-29 23:18:21 +05:30
Avuluri Venkata Sai Reddy 3011efee29
update readme, add return for getVal 2023-01-29 22:43:54 +05:30
Avuluri Venkata Sai Reddy 1278f83e1d
update readme, modify the return statment for getReference 2023-01-29 22:09:54 +05:30
Lasse Martin Jakobsen 5a062ef696
Merge pull request #45 from tusharxoxoxo/master 
Update README.md
 2022-11-25 17:46:15 +01:00
Tushar Dahiya 14c6106984
Update README.md 2022-08-29 11:08:53 +05:30
Lasse Martin Jakobsen e74ba094c9
Merge pull request #42 from jeijei4/patch-1 
Unused parameter 'num int' in getVal function
 2021-06-22 10:01:06 +02:00
JeiHO 35f1422e0f
Unused parameter 'num int' in getVal function 
Fixed unused parameter 'num int' in getVal function in "Variable scope" section.
 2021-06-21 11:16:28 -06:00
Lasse Martin Jakobsen c281014dfa
Merge pull request #38 from ibudiallo/goscopes 
add the valid return signature for the getStringResult() function
 2021-02-11 12:13:55 +01:00
Ibrahim Diallo 115b35d60c add the valid return signature for the getStringResult() function 2020-12-16 18:19:57 -08:00
Lasse Martin Jakobsen 693d670f28
Merge pull request #37 from bitcodr/improve-error-handling 
Improve error handling
 2020-11-09 09:24:21 +01:00
bitcodr d94be4024a improve error handling 2020-08-07 12:29:09 +04:30
bitcodr 8da89bdc0a improve error handling 2020-08-07 12:27:30 +04:30
Lasse Martin Jakobsen 0595e82363
Merge pull request #35 from Pungyeon/fix/issue_28 
finally fixing this issue
 2019-12-06 19:57:57 +01:00
Lasse Martin Jakobsen 4b5e0ab1d0 finally fixing this issue 2019-12-06 19:57:06 +01:00
Lasse Martin Jakobsen 50b1d72abf
Merge pull request #34 from jeffwalsh/key_id_typo 
Typo: 'id' should be 'key' in hashmap example
 2019-12-06 19:48:21 +01:00
Jeff Walsh 9256c081aa key typo in hashmap example 2019-12-03 16:17:39 -08:00
Lasse Martin Jakobsen 061ee338a3
Merge pull request #31 from Pungyeon/inverted_bool_checks 
changed bool checks to make sense
 2019-08-05 18:33:28 +02:00
Lasse Martin Jakobsen 708a68628a
Merge pull request #32 from Pungyeon/minor_cleanup 
changed made based on issue 28
 2019-08-05 10:44:41 +02:00
Lasse Martin Jakobsen a8493ef2e8 changed made based on issue 28 2019-08-05 10:41:05 +02:00
Lasse Martin Jakobsen 5272e93547 changed bool checks to make sense 2019-08-05 10:36:56 +02:00
Lasse Martin Jakobsen 1aead7e4d1
Merge pull request #29 from Pungyeon/embedded_interfaces_less_harsh 
Embedded Interfaces
 2019-07-29 10:34:27 +02:00
Lasse Martin Jakobsen d2307c8f36
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:52 +02:00
Lasse Martin Jakobsen 3605215928
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:42 +02:00
Lasse Martin Jakobsen 0f5b9126e8
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:32 +02:00
Lasse Martin Jakobsen 6920b78bc0
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:24 +02:00
Lasse Martin Jakobsen 384eaa6f30
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:16:11 +02:00
Lasse Martin Jakobsen eab8c21f28
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:15:58 +02:00
Lasse Martin Jakobsen 6bcff141fd
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:15:41 +02:00
Lasse Martin Jakobsen 2acf6d8020
Update README.md 
Co-Authored-By: Aleksandr Hovhannisyan <aleksandrhovhannisyan@gmail.com>
 2019-07-28 09:15:22 +02:00
Lasse Martin Jakobsen 052a6003ea oopsie 2019-07-23 17:09:08 +02:00
Lasse Martin Jakobsen 306e2d7118 less aggressive language and more descriptive expalanation of the downsides of using embedded interfaces 2019-07-23 17:05:50 +02:00
Aleksandr Hovhannisyan 3860f0cf5c
Reword misleading sentence under Function Length 2019-07-12 18:51:10 -04:00
Lasse Martin Jakobsen 27f52da671
Merge pull request #27 from AleksandrHovhannisyan/soften_writing 
Soften tone of writing
 2019-07-11 16:51:43 +02:00
Lasse Martin Jakobsen f9cbc4f02b
Merge pull request #26 from Pungyeon/check_interface_contracts 
added suggestions from issue #1
 2019-07-11 16:48:45 +02:00
Aleksandr Hovhannisyan 60d84410e9 Soften tone of writing in accordance with issue #25 2019-07-11 07:51:41 -04:00
Lasse Martin Jakobsen 8530359ce4
Update README.md 
Co-Authored-By: Aleksandr H <aleksandrhovhannisyan@gmail.com>
 2019-07-11 13:20:14 +02:00
Lasse Martin Jakobsen cf168cce6e
Update README.md 
Co-Authored-By: Aleksandr H <aleksandrhovhannisyan@gmail.com>
 2019-07-11 13:20:04 +02:00
Lasse Martin Jakobsen 828fd65cfa added suggestions from issue #1 2019-07-11 10:16:50 +02:00
Lasse Martin Jakobsen 10f2accf24 added suggestions from issue #1 2019-07-11 10:15:10 +02:00
Aleksandr H 4fb8a38c95
Fix typo: each others' should be each other's 2019-07-02 21:35:05 -04:00
Aleksandr H 125fc47b3b
Fix typo and clean up wording under Variable Scope 2019-07-02 21:28:30 -04:00
Lasse Martin Jakobsen efe7d709b3
Typo fix 2019-07-02 16:14:41 +02:00
Lasse Martin Jakobsen 1f5e6b3f04
Merge pull request #24 from jdugarte/patch-2 
Update README.md
 2019-07-02 16:11:29 +02:00
Jesus Dugarte b1abbd0cdf
Update README.md 2019-07-01 13:01:33 -04:00
Lasse Martin Jakobsen 0b0471eb57
Merge pull request #20 from AleksandrHovhannisyan/final-edits 
Edit rest of document (The empty interface and Summary)
 2019-07-01 15:17:45 +02:00
Aleksandr H f7bc37da6d
Accept suggestion: Clarify writing on generics and interface{} 
Co-Authored-By: Lasse Martin Jakobsen <lmj@corti.ai>
 2019-07-01 09:15:37 -04:00
Aleksandr H e9066232cd
Replace "hidden" with "contained" 
Per Pungyeon's suggestion
 2019-07-01 09:03:37 -04:00
Aleksandr H a24cd89e5c
Merge branch 'master' into final-edits 2019-07-01 09:00:20 -04:00
Lasse Martin Jakobsen de77dfcdcb
Merge pull request #12 from AleksandrHovhannisyan/master 
Edit writing up until "The empty interface{}"
 2019-07-01 14:58:54 +02:00