x/data-structure-typed
1
0
Fork 0
mirror of https://github.com/zrwusa/data-structure-typed.git synced 2024-11-23 12:54:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: In SegmentTree data structure, only use 'undefined' and abandon the design where both 'null' and 'undefined' coexist.

Browse source
This commit is contained in:
Revone 2023-11-27 09:42:49 +08:00
parent 86200435e8
commit 6694f98e67
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/data-structures/binary-tree/segment-tree.ts
View file

@ -11,16 +11,16 @@ import type { SegmentTreeNodeVal } from '../../types';
export class SegmentTreeNode {
start = 0;
end = 0;
value: SegmentTreeNodeVal | null = null;
value: SegmentTreeNodeVal | undefined = undefined;
sum = 0;
left: SegmentTreeNode | null = null;
right: SegmentTreeNode | null = null;
left: SegmentTreeNode | undefined = undefined;
right: SegmentTreeNode | undefined = undefined;
constructor(start: number, end: number, sum: number, value?: SegmentTreeNodeVal | null) {
constructor(start: number, end: number, sum: number, value?: SegmentTreeNodeVal | undefined) {
this.start = start;
this.end = end;
this.sum = sum;
this.value = value || null;
this.value = value || undefined;
}
}
@ -44,7 +44,7 @@ export class SegmentTree {
if (values.length > 0) {
this._root = this.build(start, end);
} else {
this._root = null;
this._root = undefined;
this._values = [];
}
}
@ -67,9 +67,9 @@ export class SegmentTree {
return this._end;
}
protected _root: SegmentTreeNode | null;
protected _root: SegmentTreeNode | undefined;
get root(): SegmentTreeNode | null {
get root(): SegmentTreeNode | undefined {
return this._root;
}
@ -109,7 +109,7 @@ export class SegmentTree {
* @returns The function does not return anything.
*/
updateNode(index: number, sum: number, value?: SegmentTreeNodeVal) {
const root = this.root || null;
const root = this.root || undefined;
if (!root) {
return;
}
@ -145,7 +145,7 @@ export class SegmentTree {
* @returns The function `querySumByRange` returns a number.
*/
querySumByRange(indexA: number, indexB: number): number {
const root = this.root || null;
const root = this.root || undefined;
if (!root) {
return 0;
}

2
test/unit/data-structures/binary-tree/segment-tree.test.ts
View file

@ -37,7 +37,7 @@ describe('SegmentTree', () => {
it('should handle an empty input array', () => {
// Check behavior when dealing with an empty input array
const emptySegmentTree = new SegmentTree([]);
expect(emptySegmentTree.root).toBe(null);
expect(emptySegmentTree.root).toBe(undefined);
expect(emptySegmentTree.querySumByRange(0, 2)).toBe(0); // Sum of an empty array should be 0
});