x/clean-go-article
1
0
Fork 0
mirror of https://github.com/Pungyeon/clean-go-article.git synced 2024-11-23 14:14:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #37 from bitcodr/improve-error-handling

Browse source 
Improve error handling
This commit is contained in:
Lasse Martin Jakobsen 2020-11-09 09:24:21 +01:00 committed by GitHub
parent 0595e82363 d94be4024a
commit 693d670f28
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -698,7 +698,7 @@ By simply representing the error as a variable (`ErrItemNotFound`), we've ensure
func GetItemHandler(w http.ReponseWriter, r http.Request) { func GetItemHandler(w http.ReponseWriter, r http.Request) {
item, err := clean.GetItem("123") item, err := clean.GetItem("123")
if err != nil { if err != nil {
if err == clean.ErrItemNotFound { if errors.Is(err, clean.ErrItemNotFound) {
http.Error(w, err.Error(), http.StatusNotFound) http.Error(w, err.Error(), http.StatusNotFound)
return return
} }
@ -794,7 +794,7 @@ And our HTTP handler function can then be refactored to check for a specific err
func GetItemHandler(w http.ReponseWriter, r http.Request) { func GetItemHandler(w http.ReponseWriter, r http.Request) {
item, err := clean.GetItem("123") item, err := clean.GetItem("123")
if err != nil { if err != nil {
if err.Type() == clean.ErrItemNotFound { if errors.Is(err.Type(), clean.ErrItemNotFound) {
http.Error(w, err.Error(), http.StatusNotFound) http.Error(w, err.Error(), http.StatusNotFound)
return return
} }